මේ Code එකේ අවුල මොකක්ද?

isurutmv

Well-known member
  • May 1, 2013
    1,946
    825
    113
    29
    Gampaha
    මේ Code එකේ අවුල මොකක්ද?

    මේකේ අවුල මොකක්ද බන්



    Code:
    namespace WindowsFormsApplication2
    {
        public partial class Form1 : Form
        {
            
    
            public Form1()
            {
                InitializeComponent();
            }
    
            public object Documents { get; private set; }
    
            private void button1_Click(object sender, EventArgs e)
            {
                progressBar1.Minimum = 0;
                progressBar1.Maximum = 100;
    
                IEnumerable<VideoInfo> videos = DownloadUrlResolver.GetDownloadUrls(txturl.Text);
    
                VideoInfo video = videos.First(p => p.VideoType == VideoType.Mp4 && p.Resolution == Convert.ToInt32(comboBox1.Text));
    
                if (video.RequiresDecryption)
                    DownloadUrlResolver.DecryptDownloadUrl(video);
    
                 var VideoDownloader  = new VideoDownloader(video, Path.Combine("E:/down", video.Title + video.VideoExtension));
    
                VideoDownloader.DownloadProgressChanged += Downloader_DownloadProgressChanged;
    
    
               
                VideoDownloader.Execute();
    
                
             }
    
            private void Downloader_DownloadProgressChanged(object sender, ProgressEventArgs e)
            {
                Invoke(new MethodInvoker(delegate () 
                {
    
                    progressBar1.Value = (int)e.ProgressPercentage;
                    lblprecentage.Text = $"{string.Format("{0:0.##}", e.ProgressPercentage)}%";
                    progressBar1.Update();
    
    
    
    
                }));
                    
    
    
    
                
            }
    
            private void Form1_Load(object sender, EventArgs e)
            {
                comboBox1.SelectedIndex = 0;
            }
        }
    }

    මේකේ මෙන්න මේ line එක නැතුව තිබ්බම video එක down වෙනවා but prograss bar එක වැඩ නෑ මේ line එක දැම්මාම programme එක වැඩ නෑ

    Code:
    VideoDownloader.DownloadProgressChanged += Downloader_DownloadProgressChanged;

    දන්නා කෙනෙක් කියාදෙනු මැනවි.:no::no::no::no:
     

    asiridol

    Active member
  • Dec 29, 2006
    756
    234
    43
    Still on earth
    මේකේ අවුල මොකක්ද බන්



    Code:
    namespace WindowsFormsApplication2
    {
        public partial class Form1 : Form
        {
            
    
            public Form1()
            {
                InitializeComponent();
            }
    
            public object Documents { get; private set; }
    
            private void button1_Click(object sender, EventArgs e)
            {
                progressBar1.Minimum = 0;
                progressBar1.Maximum = 100;
    
                IEnumerable<VideoInfo> videos = DownloadUrlResolver.GetDownloadUrls(txturl.Text);
    
                VideoInfo video = videos.First(p => p.VideoType == VideoType.Mp4 && p.Resolution == Convert.ToInt32(comboBox1.Text));
    
                if (video.RequiresDecryption)
                    DownloadUrlResolver.DecryptDownloadUrl(video);
    
                 var VideoDownloader  = new VideoDownloader(video, Path.Combine("E:/down", video.Title + video.VideoExtension));
    
                VideoDownloader.DownloadProgressChanged += Downloader_DownloadProgressChanged;
    
    
               
                VideoDownloader.Execute();
    
                
             }
    
            private void Downloader_DownloadProgressChanged(object sender, ProgressEventArgs e)
            {
                Invoke(new MethodInvoker(delegate () 
                {
    
                    progressBar1.Value = (int)e.ProgressPercentage;
                    lblprecentage.Text = $"{string.Format("{0:0.##}", e.ProgressPercentage)}%";
                    progressBar1.Update();
    
    
    
    
                }));
                    
    
    
    
                
            }
    
            private void Form1_Load(object sender, EventArgs e)
            {
                comboBox1.SelectedIndex = 0;
            }
        }
    }

    මේකේ මෙන්න මේ line එක නැතුව තිබ්බම video එක down වෙනවා but prograss bar එක වැඩ නෑ මේ line එක දැම්මාම programme එක වැඩ නෑ

    Code:
    VideoDownloader.DownloadProgressChanged += Downloader_DownloadProgressChanged;

    දන්නා කෙනෙක් කියාදෙනු මැනවි.:no::no::no::no:

    WPFda? mama xamarinnam dannawa... awla UI control ekak non-UI thread ekakin access karana ekada? breakpoints dala balapan
     

    isurutmv

    Well-known member
  • May 1, 2013
    1,946
    825
    113
    29
    Gampaha
    14avu2u.png
     

    asiridol

    Active member
  • Dec 29, 2006
    756
    234
    43
    Still on earth
    umba kiwwa line eke nemeine ban case eka.. umba kiwwe meka

    VideoDownloader.DownloadProgressChanged += Downloader_DownloadProgressChanged;

    pena widiyata path eka case wage..

    thawa ekak machan.. variable names hariyata deela purudu weyan.. event handlers attach karaddi meaningful names deepan.. owa danma purudu weyan.. hariyata wada karana code witharak liyala ba.. comments nathuwa code eka therum ganna tharamata readable wenna one..
     

    isurutmv

    Well-known member
  • May 1, 2013
    1,946
    825
    113
    29
    Gampaha
    umba kiwwa line eke nemeine ban case eka.. umba kiwwe meka

    VideoDownloader.DownloadProgressChanged += Downloader_DownloadProgressChanged;

    pena widiyata path eka case wage..

    na bn

    VideoDownloader.DownloadProgressChanged += Downloader_DownloadProgressChanged;

    oya line eka nathuwa programme eka wada prograssbar eka wada na habayi oya line eka dammama prograss bar eka wada na mata progress bar ekath ekka wada karanna wadiya therenne na bn oya line eka nathuwa progress bar eka wada karanna hadaganna puluwan widihak qwath athi.
     

    asiridol

    Active member
  • Dec 29, 2006
    756
    234
    43
    Still on earth
    issella meka change karapan

    var VideoDownloader = new VideoDownloader(video, Path.Combine("E://down", video.Title + video.VideoExtension));

    eeta passe balapan video.title invalid characters thiyenawada kiyala